Skip to content

Comments

Update maintenance-packages dependencies#112152

Merged
carlossanlop merged 3 commits intodotnet:mainfrom
carlossanlop:UpdateMP
Mar 25, 2025
Merged

Update maintenance-packages dependencies#112152
carlossanlop merged 3 commits intodotnet:mainfrom
carlossanlop:UpdateMP

Conversation

@carlossanlop
Copy link
Contributor

@carlossanlop carlossanlop commented Feb 4, 2025 •
edited
Loading

This PR is result of testing the parallel dependency updates to ensure source-build does not break: dotnet/dotnet#133

IMPORTANT: I need to merge this PR at the same time as all the other PRs in the other repos, to prevent breaking the dependency ingestion in the dotnet/sdk repo.

@carlossanlop carlossanlop added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) area-Infrastructure-libraries labels Feb 4, 2025
@carlossanlop carlossanlop self-assigned this Feb 4, 2025
@carlossanlop carlossanlop requested a review from a team February 6, 2025 17:34
@ericstj
Copy link
Member

ericstj commented Feb 19, 2025

Seems the build is failing because these versions are not available on any feed yet. Do we need to get these released first and mirrored to dotnet-public?

@carlossanlop carlossanlop removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Mar 19, 2025
@carlossanlop
Copy link
Contributor Author

carlossanlop commented Mar 19, 2025

This is ready to review @ericstj @ViktorHofer

@carlossanlop carlossanlop changed the title Manually update maintenance-packages dependencies System.ValueTuple and System.Runtime.CompilerServices.Unsafe Manually update maintenance-packages dependencies Mar 19, 2025
@carlossanlop carlossanlop changed the title Manually update maintenance-packages dependencies Update maintenance-packages dependencies Mar 19, 2025
@ViktorHofer
Copy link
Member

ViktorHofer commented Mar 19, 2025 •
edited
Loading

/__w/1/s/artifacts/sb/src/src/libraries/Microsoft.Extensions.Logging/src/Logger.cs(241,17): error CS0433: The type 'ReadOnlySpan' exists in both 'System.Memory, Version=4.0.3.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' and 'netstandard, Version=2.1.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' [/__w/1/s/artifacts/sb/src/src/libraries/Microsoft.Extensions.Logging/src/Microsoft.Extensions.Logging.csproj::TargetFramework=netstandard2.1]

src/libraries/System.Threading.Channels/ref/System.Threading.Channels.cs(51,47): error CS0433: (NETCORE_ENGINEERING_TELEMETRY=Build) The type 'ValueTask' exists in both 'System.Threading.Tasks.Extensions, Version=4.2.2.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' and 'netstandard, Version=2.1.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'

from the source-build job

@build-analysis build-analysis bot mentioned this pull request Mar 20, 2025
Closed
3 tasks
@carlossanlop carlossanlop mentioned this pull request Mar 24, 2025
Merged
@carlossanlop
Copy link
Contributor Author

carlossanlop commented Mar 24, 2025

The deps flow PR containing the required prebuilts has been merged: #113820

Updating branch now.

This was referenced Mar 25, 2025
Open
Closed
Closed
@carlossanlop carlossanlop mentioned this pull request Mar 25, 2025
Closed
@carlossanlop
Copy link
Contributor Author

carlossanlop commented Mar 25, 2025

/ba-g timeouts, unrelated

@carlossanlop carlossanlop merged commit 12fc2d2 into dotnet:main Mar 25, 2025
150 of 156 checks passed
@carlossanlop carlossanlop deleted the UpdateMP branch March 25, 2025 16:42
This was referenced Apr 3, 2025
Closed
Closed
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees

@carlossanlop carlossanlop

Labels

area-Infrastructure-libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carlossanlop @ericstj @ViktorHofer